-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsers
: remove explicit check for the retrieved folder's existence
#580
Conversation
dfbccf3
to
45edbf2
Compare
Hmm, I feel it's a bit early to remove Anyway, maybe we could just add |
Fair enough, but this change requires 1.4. However, it is not pressing, so we can keep it open until we feel 1.4 is stable enough |
Alright, thanks. Did I understand it right that the current code will work fine with 1.3 and 1.4, but at 1.4 what we're removing here is essentially dead code? And just out of curiosity: Does |
Yes
It does define it, but it uses I think it is fine, because the exit codes defined here in the plugin stem from the alpha days where I put them as a pre-caution. |
@greschd although this change is not really pressing, the other PR #581 to add support for |
As of `aiida-core==1.4.0`, the engine itself will check for the presence of the retrieved folder. If it is missing, which is really just a bug in `aiida-core` the engine will terminate the process and not call the parser. Anyway there would be no point since there is nothing to parse. This means that now if the parser is called, it is guaranteed that the retrieve folder exists and so we no longer have to explicitly check for it. Since this is only valid from `aiida-core>=1.4` we update the dependency requirement. We also require `aiida-core>=1.4.2` because `1.4.0` and `1.4.1` contain a bug where the content of files in `local_copy_list` are copied to the repository even though they shouldn't. For this plugin this means that mostly the content of the pseudo potentials are duplicated everytime in the repository, which will bloat the repository unnecessarily.
45edbf2
to
0165ef4
Compare
Right then, let's do this. I guess if I need to use |
…#580) As of `aiida-core==1.4.0`, the engine itself will check for the presence of the retrieved folder. If it is missing, which is really just a bug in `aiida-core` the engine will terminate the process and not call the parser. Anyway there would be no point since there is nothing to parse. This means that now if the parser is called, it is guaranteed that the retrieve folder exists and so we no longer have to explicitly check for it. Since this is only valid from `aiida-core>=1.4` we update the dependency requirement. We also require `aiida-core>=1.4.2` because `1.4.0` and `1.4.1` contain a bug where the content of files in `local_copy_list` are copied to the repository even though they shouldn't. For this plugin this means that mostly the content of the pseudo potentials are duplicated every time in the repository, which will bloat the repository unnecessarily.
Fixes #577
As of
aiida-core==1.4.0
, the engine itself will check for the presenceof the retrieved folder. If it is missing, which is really just a bug in
aiida-core
the engine will terminate the process and not call theparser. Anyway there would be no point since there is nothing to parse.
This means that now if the parser is called, it is guaranteed that the
retrieve folder exists and so we no longer have to explicitly check for
it.
Since this is only valid from
aiida-core>=1.4
we update the dependencyrequirement. We also require
aiida-core>=1.4.2
because1.4.0
and1.4.1
contain a bug where the content of files inlocal_copy_list
are copied to the repository even though they shouldn't. For this plugin
this means that mostly the content of the pseudo potentials are
duplicated everytime in the repository, which will bloat the repository
unnecessarily.